[webkit-reviews] review denied: [Bug 8707] event.clientX and event.clientY should be relative to the viewport, not the canvas : [Attachment 8963] Improved patch+testcase

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 8707: event.clientX and event.clientY should be relative to the viewport,
not the canvas
http://bugzilla.opendarwin.org/show_bug.cgi?id=8707

Attachment 8963: Improved patch+testcase
http://bugzilla.opendarwin.org/attachment.cgi?id=8963&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This seems like a big step in the right direction.

But I think it's confusing to have local variables named offsetX and offsetY
and parameter to the MouseEvent/WheelEvent constructors that are entirely
different things than MouseEvent's own offsetX and offsetY properties.

Similarly, it doesn't make sense to me that the clientX and clientY parameters
are no longer clientX and clientY! If their meaning is changing, then the name
should change to. And it should only be called clientX and clientY if that's
really what these are named.

Also, since the WheelEvent constructor does take a pointer to the abstract
view, then we can get from that to the FrameView, so we don't need to add
another parameter to the constructors -- not sure if that's better or not, but
I think it probably is.