[webkit-reviews] review requested: [Bug 8177] Javascript search incredibly slow : [Attachment 8951] proposed patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Jun 21 11:44:39 PDT 2006

Alexey Proskuryakov <ap at nypop.com> has asked  for review:
Bug 8177: Javascript search incredibly slow

Attachment 8951: proposed patch

------- Additional Comments from Alexey Proskuryakov <ap at nypop.com>
Addressed the comments. Also changed the HashMap to use AtomicStringImpl*.

Of course, one can create an example for which this patch increases memory
requirements significantly, but this is not much different from the existing
m_elementsById or m_selectedRadioButtons caches... It's hard for me to estimate
whether this is a practical issue.

More information about the webkit-reviews mailing list