[webkit-reviews] review requested: [Bug 9523] More Win32 build
bustage : [Attachment 8938] patch
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Wed Jun 21 00:14:01 PDT 2006
Ben Goodger <bengoodger at gmail.com> has asked for review:
Bug 9523: More Win32 build bustage
http://bugzilla.opendarwin.org/show_bug.cgi?id=9523
Attachment 8938: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=8938&action=edit
------- Additional Comments from Ben Goodger <bengoodger at gmail.com>
Adds/removes files from WebCore.vcproj and adjusts shouldInterruptJavaScript
signature (alternatively, the impl should not be const, let me know)
ChangeLog entry:
* WebCore.vcproj/WebCore/WebCore.vcproj:
Add DeprecatedRenderSelect.cpp/h
Remove RenderSelect.cpp/h
Add BeforeUnloadEvent, Clipboard, ClipboardEvent, Event, KeyboardEvent,
MouseEvent, MouseRelatedEvent, MutationEvent, RegisteredEventListener, UIEvent,
UIEventWithKeyState, WheelEvent .h/.cpp
Remove dom2_eventsimpl.h/cpp
* WebCore/bridge/win/FrameWin.cpp
(WebCore::shouldInterruptJavaScript):
This method is supposed to be implemented on FrameWin
* WebCore/page/Frame.h
(WebCore::Frame):
abstract method should match const-ness of implementation
More information about the webkit-reviews
mailing list