[webkit-reviews] review denied: [Bug 9509] Would like a way to pause/resume XML parsing : [Attachment 8925] Patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Jun 20 02:41:01 PDT 2006

Maciej Stachowiak <mjs at apple.com> has denied Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 9509: Would like a way to pause/resume XML parsing

Attachment 8925: Patch

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
On the substance this looks ok, but I think it would be better to use
subclasses instead of just a tagged union for PendingCallbacks, this would
allow elimination of most of the switch statements also. Suggest rewriting
along theselines.

More information about the webkit-reviews mailing list