[webkit-reviews] review granted: [Bug 9485] Teach svn-apply and svn-unapply to use full path names : [Attachment 8887] Patch v1

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Jun 18 16:48:15 PDT 2006


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 9485: Teach svn-apply and svn-unapply to use full path names
http://bugzilla.opendarwin.org/show_bug.cgi?id=9485

Attachment 8887: Patch v1
http://bugzilla.opendarwin.org/attachment.cgi?id=8887&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
cvs couldn't handle full paths; that's why the code was doing complicated
unnecessary stuff before. Once we switched to svn, we didn't need that code.

I don't understand why we need to chdir at all any more. I think that
addDirectoriesIfNeeded also should use full paths.

r=me



More information about the webkit-reviews mailing list