[webkit-reviews] review denied: [Bug 8707] event.clientX and event.clientY should be relative to the viewport, not the canvas : [Attachment 8906] First attempt

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Jun 18 16:39:22 PDT 2006


Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 8707: event.clientX and event.clientY should be relative to the viewport,
not the canvas
http://bugzilla.opendarwin.org/show_bug.cgi?id=8707

Attachment 8906: First attempt
http://bugzilla.opendarwin.org/attachment.cgi?id=8906&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Sure, this fixes clientX and clientY, but what does it do to all the other X
and Y properties on the event? We need a test case that checks all of those.

I remember trying a code change like this one, and it broke lots of things.

All bug fixes need a test, and this one lacks a test.



More information about the webkit-reviews mailing list