[webkit-reviews] review granted: [Bug 9181] Complete DOMUIEvent Obj-C API to reflect UIEvent : [Attachment 8864] public-pending DOMKeyboardEvent, DOMWheelEvent plus testcase

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Jun 18 11:35:13 PDT 2006


Geoffrey Garen <ggaren at apple.com> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 9181: Complete DOMUIEvent Obj-C API to reflect UIEvent
http://bugzilla.opendarwin.org/show_bug.cgi?id=9181

Attachment 8864: public-pending DOMKeyboardEvent, DOMWheelEvent plus testcase
http://bugzilla.opendarwin.org/attachment.cgi?id=8864&action=edit

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Good work.

I don't think returning the non-public object from the public method is a big
deal. From the public API standpoint, it will just be a DOMUIEvent.

There's no need to use a separate file for non-W3C additions. I don't think
that's how we handle other private-pending-public API. Also, the Objc bindings
will be autogenerated eventually, and our IDL files probably won't distinguish
W3C and non-W3C interfaces.

+				EXPORTED_SYMBOLS_FILE = "";

How did this line sneak into the project diff? Is it an XCode version quirk, or
will it nuke WebCore's .exp file? I don't *think* it will, since we specify the
.exp file through OTHER_LDFLAGS, not EXPORTED_SYMBOLS_FILE.

Anyway, addressing the comments above is optional.  r=me

Whoever lands this should make sure that WebCore still builds with its .exp
file.



More information about the webkit-reviews mailing list