[webkit-reviews] review granted: [Bug 9150] DumpRenderTree should be able to keep URL history during runs : [Attachment 8893] Patch v4

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Jun 17 21:05:33 PDT 2006


Geoffrey Garen <ggaren at apple.com> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 9150: DumpRenderTree should be able to keep URL history during runs
http://bugzilla.opendarwin.org/show_bug.cgi?id=9150

Attachment 8893: Patch v4
http://bugzilla.opendarwin.org/attachment.cgi?id=8893&action=edit

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Looks good, and seems to address Darin's comments. r=me

In the layout test, using a fake mouse event to click the link seems a little
funny. I'm pretty sure that dispatching an event through the DOM would work
just as well. Just for future reference.

Part of me also thinks that the repaint and history code should go into
separate "controller" objects, not layoutTestController, which should limit
itself to direct control of the test mechanism.



More information about the webkit-reviews mailing list