[webkit-reviews] review requested: [Bug 9485] Teach svn-apply and svn-unapply to use full path names : [Attachment 8887] Patch v1

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Jun 17 09:27:50 PDT 2006


David Kilzer (ddkilzer) <ddkilzer at kilzer.net> has asked  for review:
Bug 9485: Teach svn-apply and svn-unapply to use full path names
http://bugzilla.opendarwin.org/show_bug.cgi?id=9485

Attachment 8887: Patch v1
http://bugzilla.opendarwin.org/attachment.cgi?id=8887&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at kilzer.net>
Patch v1 does the following:

svn-apply:
- Added "use warnings;"
- Used subroutine prototypes
- Added command-line argument validation and a -h|--help argument with a help
message
- Changed merge feature to operate on full paths
- Added "exit 0;" statement at end of main code path
- Renamed $fullpath to $fullPath
- Changed patch() subroutine to use $fullPath instead of $base and to inline
usages of $prefix
- Changed handleBinaryChange() subroutine to use a full path
- Renamed chdirAddingDirectoriesIfNeeded() to addDirectoriesIfNeeded() and
chdir back to $startDir when done

svn-unapply:
- Added new missing feature for removing newly added directories
- Added "use warnings;"
- Used subroutine prototypes
- Added command-line argument validation and a -h|--help argument with a help
message
- Added "exit 0;" statement at end of main code path
- Renamed $fullpath to $fullPath
- Changed patch() subroutine to use $fullPath instead of $base and to remove
usages of $prefix



More information about the webkit-reviews mailing list