[webkit-reviews] review denied: [Bug 9475] CSS3: Add support for text-effect: outline. : [Attachment 8870] Patch version 1

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Jun 16 16:06:12 PDT 2006

Dave Hyatt <hyatt at apple.com> has denied Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 9475: CSS3: Add support for text-effect: outline.

Attachment 8870: Patch version 1

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
(1) It's highly unlikely that this property will keep the same name if/when
this spec is ever revived.  It's really more of a text-effect than a
font-effect.  Your property should therefore be


and not just font-effect.  I think we should suggest that the property be
renamed to text-effect though, because to me this is more like text shadow than
it is like other font options.

(2) This is just a way you draw.  It has no effect on metrics.	Therefore this
should not be part of the actual font information but just held separately in
the style.  It should not be included as one of the properties that have to be
checked first either, since it really isn't a font property.

(3) You should go ahead and fully parse the property, even if embossed/engraved
don't do anything yet.

(4) There's some crazy indentation in the patch (in cssstyleselector.cpp).

More information about the webkit-reviews mailing list