[webkit-reviews] review requested: [Bug 3233] CSS2: Web Kit does not support the :lang pseudo-class : [Attachment 8856] Patch rev 1.4

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Jun 15 08:49:56 PDT 2006


Nicholas Shanks <contact at nickshanks.com> has asked  for review:
Bug 3233: CSS2: Web Kit does not support the :lang pseudo-class
http://bugzilla.opendarwin.org/show_bug.cgi?id=3233

Attachment 8856: Patch rev 1.4
http://bugzilla.opendarwin.org/attachment.cgi?id=8856&action=edit

------- Additional Comments from Nicholas Shanks <contact at nickshanks.com>
I have tried to address Eric's first concern, I really have, but due to the
fact that AtomicString (and DeprecatedString) both have constructors and
destructors, they are not permitted within a union. Everything else is either
fixed or open to suggestion and later adjustment (like the variable name).

I am submitting this as the final patch offering for this bug. It really needs
to be committed and into the tree as has been here for 12 months now.

Note that this patch is less ambitious than I first wanted: it does not attempt
to inherit the language from parent elements nor the HTTP headers, as that was
causing instability. I will open a separate bug to track that.



More information about the webkit-reviews mailing list