[webkit-reviews] review denied: [Bug 6282] Adding new Option with new Option(text, value, defaultSelected, selected) fails to update selectedIndex : [Attachment 8801] Now with testcase

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 6282: Adding new Option with new Option(text, value, defaultSelected,
selected) fails to update selectedIndex
http://bugzilla.opendarwin.org/show_bug.cgi?id=6282

Attachment 8801: Now with testcase
http://bugzilla.opendarwin.org/attachment.cgi?id=8801&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Test case looks great, but also need expected results! (including pixel
results, unless it's a "dump as text test", which is the preferred style).

HTMLSelectElement::setOption and HTMLSelectElement::setLength are written here
assuming that the passed in "ec" is already 0. In general, functions should not
be written that way. Callers are not obliged to set up ec before calling if
they intend to ignore it. The rule is "caller must set exception code to 0 if
and only if caller looks at it to determine success; implementers may set the
exception code to 0 or leave it untouched on success".

Otherwise, looks great.