[webkit-reviews] review denied: [Bug 9314] Relative positioned block size doesnt update root layer size : [Attachment 8804] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Jun 11 02:38:42 PDT 2006

Dave Hyatt <hyatt at apple.com> has denied Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 9314: Relative positioned block size doesnt update root layer size

Attachment 8804: patch

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Actually hold up.  I think there's a better way to do this.  There are more
mistakes than just the scroll position being wrong.

Basically the overflowWidth/Height/Left/Top members of RenderBlock are all
wrong.	When these values are computed, they don't account for relative
positioning.  This means we incorrectly think relpositioned objects might
overflow (when they don't) and vice versa.

Rather than patching leftmost/rightmost/lowestPosition, I think we should patch
the computation of m_overflowLeft/Top/Width/Height to factor in relative
position offsets when examining children.

More information about the webkit-reviews mailing list