[webkit-reviews] review requested: [Bug 6282] Adding new Option with new Option(text, value, defaultSelected, selected) fails to update selectedIndex : [Attachment 8801] Now with testcase

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Jun 10 14:55:33 PDT 2006


Rob Buis <rwlbuis at xs4all.nl> has asked	for review:
Bug 6282: Adding new Option with new Option(text, value, defaultSelected,
selected) fails to update selectedIndex
http://bugzilla.opendarwin.org/show_bug.cgi?id=6282

Attachment 8801: Now with testcase
http://bugzilla.opendarwin.org/attachment.cgi?id=8801&action=edit

------- Additional Comments from Rob Buis <rwlbuis at xs4all.nl>
I made two testcases, and adjusted the code when I noticed differences with
firefox.
For the normal test we have the same results, but the multiple selection one
differs, I
think we do it according to spec though. Also the use of getNumber may need
some
attention, could those values get too big? It seems we have to support setting
lengths
using floats, firefox supports it.
Cheers,

Rob.



More information about the webkit-reviews mailing list