[webkit-reviews] review granted: [Bug 8515] Linux porting compile bug : [Attachment 8780] Latest patch for linux changes

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Jun 9 11:44:50 PDT 2006

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 8515: Linux porting compile bug

Attachment 8780: Latest patch for linux changes

------- Additional Comments from Darin Adler <darin at apple.com>
+    void setFont(cairo_t* cr) const;

We would leave out "cr" here.

+    Glyph getGlyphIndex(UChar c) const { return m_font.index (c); }

We would not put a space after index and before "(c)".

I think you should use round rather than nearbyint -- nearbyint is affected by
the prevailing rounding mode.

 #include "config.h"
+#include <math.h>
 #include "HTMLCanvasElement.h"

The <math.h> include should go a little further down. The concept is that the
.cpp file includes its own header file.

These are minor issues, so r=me.

More information about the webkit-reviews mailing list