[webkit-reviews] review requested: [Bug 7395] Table not properly re-flowed when floated div removed from layout : [Attachment 8783] Fix (no layout test or change log)

[bugzilla-request-daemon at opendarwin.org]

opendarwin.org at mitzpettel.com has asked Dave Hyatt <hyatt at apple.com> for
review:
Bug 7395: Table not properly re-flowed when floated div removed from layout
http://bugzilla.opendarwin.org/show_bug.cgi?id=7395

Attachment 8783: Fix (no layout test or change log)
http://bugzilla.opendarwin.org/attachment.cgi?id=8783&action=edit

------- Additional Comments from opendarwin.org at mitzpettel.com
This fixes the test case and also this CSS2.1 test:
css2.1/t0905-c5525-fltmult-00-d-g.html

I case I'm concerned about is actually the case that currently works, i.e. the
paragraph. The only reason it reflows is that containsFloats() keeps returning
true even after the last float is removed (it checks that m_floatingObjects is
not 0 but otherwise doesn't check if there are any objects in the list), so
layoutInlineChildren always does a full layout (of any block that ever had
floats at some point). I think you need a different mechanism for signaling the
need for a full layout in the case of a float being removed, but I can't think
of one.