[webkit-reviews] review requested: [Bug 9350] Use pathcmp() when sorting paths in svn-create-patch : [Attachment 8782] Patch v2

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Jun 9 02:34:30 PDT 2006


David Kilzer (ddkilzer) <ddkilzer at kilzer.net> has asked  for review:
Bug 9350: Use pathcmp() when sorting paths in svn-create-patch
http://bugzilla.opendarwin.org/show_bug.cgi?id=9350

Attachment 8782: Patch v2
http://bugzilla.opendarwin.org/attachment.cgi?id=8782&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at kilzer.net>
New in Patch v2:

- Nothing from Patch v1 was kept except for the code clean-up in
svn-create-patch (subroutine prototypes and addition of -h|--help switch and
printUsage()).
- Modified splitpath() in run-webkit-tests to use File::Basename methods
instead of regex.
- Copied numericcmp(), pathcmp() and splitpath() from run-webkit-tests to
svn-create-path.
- Use pathcmp() on sort() functions in svn-create-path.



More information about the webkit-reviews mailing list