[webkit-reviews] review granted: [Bug 9350] Use pathcmp() when sorting paths in svn-create-patch : [Attachment 8764] Patch v1

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Jun 8 09:21:16 PDT 2006

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 9350: Use pathcmp() when sorting paths in svn-create-patch

Attachment 8764: Patch v1

------- Additional Comments from Darin Adler <darin at apple.com>
I'm not entirely happy with the name "Util", with the idea of creating a "lib"
subdirectory of the Scripts directory, or with moving these functions to a
library. On the other hand, I see the appeal of sharing the code.

1) In general, I'm not at a fan of using abbreviations unless the full word is
too long to be practical to use.

2) I don't like the name "Utilities". That's a catch-all term and it's hard to
know what things are or are not utilities. For example, I'd prefer a name like
Sorting or SortingFunctions for a library of functions for sorting.

3) Up until this point the only library we've had is webkitdirs. As I created
scripts I went out of my way to keep each the number of scripts small, keep
each script as small as possible and relatively independent; I hope this makes
them relatively hackable.

Given all of that, I have mixed feelings about the cost/benefit of the patch,
even though it was my suggestion to use the pathcmp sort function.

I guess I'll mark this review+ despite my reservations, but please consider my

More information about the webkit-reviews mailing list