[webkit-reviews] review requested: [Bug 9350] Use pathcmp() when sorting paths in svn-create-patch : [Attachment 8764] Patch v1

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Jun 7 20:35:59 PDT 2006


David Kilzer (ddkilzer) <ddkilzer at kilzer.net> has asked  for review:
Bug 9350: Use pathcmp() when sorting paths in svn-create-patch
http://bugzilla.opendarwin.org/show_bug.cgi?id=9350

Attachment 8764: Patch v1
http://bugzilla.opendarwin.org/attachment.cgi?id=8764&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at kilzer.net>
- Moved pathcmp() and helper methods to WebKit::Util module.
- Created WebKitTools/Scripts/lib directory for modules.  (I hate *.pm files
inside the Scripts directory.)
- Changed svn-create-patch to use pathcmp() subroutine.
- Various Perl clean-up in svn-create-patch (subroutine prototypes; added -h
command-line switch).



More information about the webkit-reviews mailing list