[webkit-reviews] review denied: [Bug 9121] REGRESSION: [Incremental Repaint] DHTML movement test failures : [Attachment 8696] Patch for both problems, including change log and tests

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Jun 4 11:59:59 PDT 2006


Dave Hyatt <hyatt at apple.com> has denied Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 9121: REGRESSION: [Incremental Repaint] DHTML movement test failures
http://bugzilla.opendarwin.org/show_bug.cgi?id=9121

Attachment 8696: Patch for both problems, including change log and tests
http://bugzilla.opendarwin.org/attachment.cgi?id=8696&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
This check:

if (isRenderBlock() && (!isInline() || isReplaced()))

is probably overkill.  The only time a RenderBlock becomes inline (without
being an inline-block) is when it's a compact or run-in.

I'd just do:

if (isRenderBlock())

instead and not worry about optimizing for the compact/run-in case.



More information about the webkit-reviews mailing list