[webkit-reviews] review requested: [Bug 9296] Performance improvement for svn-create-patch : [Attachment 8682] Patch v1

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Jun 3 13:16:10 PDT 2006


David Kilzer (ddkilzer) <ddkilzer at kilzer.net> has asked  for review:
Bug 9296: Performance improvement for svn-create-patch
http://bugzilla.opendarwin.org/show_bug.cgi?id=9296

Attachment 8682: Patch v1
http://bugzilla.opendarwin.org/attachment.cgi?id=8682&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at kilzer.net>
Patch v1 undefines the $indexPath variable so that the three regex replacement
statements do not get run after the paths in each patch header are processed.

Note that I didn't actually do any benchmarking; this seemed like an obvious
performance win.



More information about the webkit-reviews mailing list