[webkit-reviews] review granted: [Bug 9035] document.evaluate and createNSResolver miss on namespaced elements : [Attachment 8680] Patch

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 9035: document.evaluate and createNSResolver miss on namespaced elements
http://bugzilla.opendarwin.org/show_bug.cgi?id=9035

Attachment 8680: Patch
http://bugzilla.opendarwin.org/attachment.cgi?id=8680&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
-Step::Step(AxisType axis, const String& nodeTest, const Vector<Predicate*>&
predicates)
+Step::Step(AxisType axis, const String& nodeTest, const Vector<Predicate*>
&predicates)

The above is not a good change.

+    Parser *parser = Parser::current();

We put the * next to the type.

+    if (!parser->m_currentNamespaceURI.isNull()) {
+	 m_namespaceURI = parser->m_currentNamespaceURI;
+	 parser->m_currentNamespaceURI = String();
+    }

Why the if here? Seems that check should be omitted.

+	     $$ = new String($1->deprecatedString().mid(colon + 1));

This could use String::substring and then you would not need to bother with the
conversion to/from DeprecatedString.

r=me