[webkit-reviews] review requested: [Bug 9290] Teach svn-apply and svn-unapply to patch ChangeLogs cleanly : [Attachment 8677] Patch v2

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Jun 3 04:58:04 PDT 2006

David Kilzer (ddkilzer) <ddkilzer at kilzer.net> has asked  for review:
Bug 9290: Teach svn-apply and svn-unapply to patch ChangeLogs cleanly

Attachment 8677: Patch v2

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at kilzer.net>
Changes since Patch v1:

- Added 2006 to copyright years in svn-apply.

- Extracted out applyPatch() method in svn-apply, and unapplyPatch() method in

- Don't remove ChangeLog.orig if it existed before running either svn-apply or
svn-unapply per Comment #2.  (I'm not sure this buys you much since patch(1)
will overwrite the contents of ChangeLog.orig if it exists before the patch is

- Simplify reversing a deletion in svn-unapply by calling "svn revert".  (This
issue was found while trying to unapply a real patch from Bug 7281.)

More information about the webkit-reviews mailing list