[webkit-reviews] review cancelled: [Bug 9290] Teach svn-apply and svn-unapply to patch ChangeLogs cleanly : [Attachment 8676] Patch v1

[bugzilla-request-daemon at opendarwin.org]

David Kilzer (ddkilzer) <ddkilzer at kilzer.net> has cancelled David Kilzer
(ddkilzer) <ddkilzer at kilzer.net>'s request for review:
Bug 9290: Teach svn-apply and svn-unapply to patch ChangeLogs cleanly
http://bugzilla.opendarwin.org/show_bug.cgi?id=9290

Attachment 8676: Patch v1
http://bugzilla.opendarwin.org/attachment.cgi?id=8676&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at kilzer.net>
Changes since Patch v1:

- Added 2006 to copyright years in svn-apply.

- Extracted out applyPatch() method in svn-apply, and unapplyPatch() method in
svn-unapply.

- Don't remove ChangeLog.orig if it existed before running either svn-apply or
svn-unapply per Comment #2.  (I'm not sure this buys you much since patch(1)
will overwrite the contents of ChangeLog.orig if it exists before the patch is
applied.)

- Simplify reversing a deletion in svn-unapply by calling "svn revert".  (This
issue was found while trying to unapply a real patch from Bug 7281.)