[webkit-reviews] review granted: [Bug 6309] multiple problems prevent bookmarking/back button technique for AJAX/DHTML applications from working : [Attachment 8642] Patch

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 6309: multiple problems prevent bookmarking/back button technique for
AJAX/DHTML applications from working
http://bugzilla.opendarwin.org/show_bug.cgi?id=6309

Attachment 8642: Patch
http://bugzilla.opendarwin.org/attachment.cgi?id=8642&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Since == already works on KURL, it seems to me that we only need a function
that does the "== ignoring hash" operation. Also, for symmetric operations like
equality, I prefer functions to members. So I'd like to see the isEqualTo
function renamed and remove the boolean parameter and be a "free" function
rather than a member function.

In historyURL: we should not use braces around single-line if statements.

Otherwise looks good, and those are nitpicks, so r=me.