[webkit-reviews] review denied: [Bug 10176] Make WebCore compile with -Wundef : [Attachment 9783] patch

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 10176: Make WebCore compile with -Wundef
http://bugzilla.opendarwin.org/show_bug.cgi?id=10176

Attachment 9783: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=9783&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+#if defined(SPEED_DEBUG) && SPEED_DEBUG < 1

That's definitely wrong. This needs to compile if SPEED_DEBUG is not defined.

THe other ones look pretty good, but I'd prefer that it consistently use #ifdef
rather than a mix of #ifdef and #if defined.

Seems that all the #if __APPLE__ need to be changed too, although not on the OS
X platform.

review- because of the SPEED_DEBUG mistake.