[webkit-reviews] review requested: [Bug 10176] Make WebCore compile with -Wundef : [Attachment 9783] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Jul 31 18:19:56 PDT 2006


Sam Weinig <sam.weinig at gmail.com> has asked  for review:
Bug 10176: Make WebCore compile with -Wundef
http://bugzilla.opendarwin.org/show_bug.cgi?id=10176

Attachment 9783: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=9783&action=edit

------- Additional Comments from Sam Weinig <sam.weinig at gmail.com>
This patch adds -Wundef to WebCore, WebKit, JavaScriptCore, and JavaScriptGlue
and fixes them so that they compile.  One idea I had was to hold off on this
particular version and use this as an opportunity to convert to using the
PLATFORM() macros from WTF.  We could always do that in another patch as well.



More information about the webkit-reviews mailing list