[webkit-reviews] review requested: [Bug 3438] incorrect display of transparent 1x1 PNGs : [Attachment 9764] Use non-premul, 8-bit integer bitmap context

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Jul 30 12:05:39 PDT 2006


opendarwin.org at mitzpettel.com has asked  for review:
Bug 3438: incorrect display of transparent 1x1 PNGs
http://bugzilla.opendarwin.org/show_bug.cgi?id=3438

Attachment 9764: Use non-premul, 8-bit integer bitmap context
http://bugzilla.opendarwin.org/attachment.cgi?id=9764&action=edit

------- Additional Comments from opendarwin.org at mitzpettel.com
Patch is missing a test and a change log, but I'd like to get feedback on
switching to integers (is there any reason to use floats when you convert to
int anyway?) and on whether I should use another type for the 8-bit quantity
instead of unsigned char.



More information about the webkit-reviews mailing list