[webkit-reviews] review granted: [Bug 10158] REGRESSION: Selection highlight is dark and opaque when solid-color images are used : [Attachment 9761] Add calls to save and restore the graphics context

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 10158: REGRESSION: Selection highlight is dark and opaque when solid-color
images are used
http://bugzilla.opendarwin.org/show_bug.cgi?id=10158

Attachment 9761: Add calls to save and restore the graphics context
http://bugzilla.opendarwin.org/attachment.cgi?id=9761&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
It's not clear what the best policy is for various graphics context attributes.


For some, we assume that every user has to set the value before drawing. For
others, it's the responsibility of the client to save and restore if they
change an attribute.

I suppose that composite operation is a member of the latter group. But I don't
like the ad hoc nature and lack of clarity about which operations fall into
which category.

r=me