[webkit-reviews] review requested: [Bug 10080] Adopt gcc -pedantic
changes from the Unity project to improve cross-compiler
compatibility : [Attachment 9757] patch 4
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Sat Jul 29 14:28:11 PDT 2006
Sam Weinig <sam.weinig at gmail.com> has asked for review:
Bug 10080: Adopt gcc -pedantic changes from the Unity project to improve
cross-compiler compatibility
http://bugzilla.opendarwin.org/show_bug.cgi?id=10080
Attachment 9757: patch 4
http://bugzilla.opendarwin.org/attachment.cgi?id=9757&action=edit
------- Additional Comments from Sam Weinig <sam.weinig at gmail.com>
Now uses -numeric_limits<double>::infinity() instead of
-numeric_limits<double>::max() (which was instead of -HUGE_VAL). For floating
point numbers numeric_limits<>::min() is actually the smallest positive number,
so this is our best bet. Added other changes to ChangeLogs. The reason to use
C style comments in those prefix headers is really only to give the compiler
what it wants. I think that they might get included in some non-C++ files and
therefore the pedantic setting warns about it.
More information about the webkit-reviews
mailing list