[webkit-reviews] review denied: [Bug 10080] Adopt gcc -pedantic changes from the Unity project to improve cross-compiler compatibility : [Attachment 9750] patch 3

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 10080: Adopt gcc -pedantic changes from the Unity project to improve
cross-compiler compatibility
http://bugzilla.opendarwin.org/show_bug.cgi?id=10080

Attachment 9750: patch 3
http://bugzilla.opendarwin.org/attachment.cgi?id=9750&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+	 Vector<JSValueRef> arguments(argumentCount);

For efficiency, this should use the feature of Vector where it uses storage on
the stack if it fits. Like this:

	Vector<JSValueRef, 256> arguments(argumentCount);

The comments in the change log do not mention the change from C++ style
comments to plain C comments, nor the motivation for that change. I'd like to
understand why a Mac-OS-X-only prefix file needs that change.

Change log doesn't mention changing from ABS macro to abs function.

Change log doesn't mention changing from -HUGE_VAL to
-numeric_limits<double>::max(), but also, that should probably be
numeric_limits<double>::min() instead. Also -HUGE_VAL is actually negative
infinity, which is even better. Is there some portable way to get negative
infinity?