[webkit-reviews] review granted: [Bug 10096] Bring linux port uptodate : [Attachment 9709] Latest patch added changlog and missing Popup impl

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Jul 27 08:29:54 PDT 2006


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 10096: Bring linux port uptodate
http://bugzilla.opendarwin.org/show_bug.cgi?id=10096

Attachment 9709: Latest patch added changlog and missing Popup impl
http://bugzilla.opendarwin.org/attachment.cgi?id=9709&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
If you're not adding a real implementation, and it's just stubs, I suggest
putting the functions in the stubs file instead of in the actual correct
location. We've found it makes it easy to keep track fo the work that needs to
be done.

These change log entries don't match the formats of others -- they use tabs,
are missing trailing colons, and only have per-file comments, no overall
commments about what's being done.

But I am feeling "weak" so review+ despite these two issues.



More information about the webkit-reviews mailing list