[webkit-reviews] review denied: [Bug 10096] Bring linux port
uptodate : [Attachment 9691] Linux patch without idl changes
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Wed Jul 26 13:56:51 PDT 2006
Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 10096: Bring linux port uptodate
http://bugzilla.opendarwin.org/show_bug.cgi?id=10096
Attachment 9691: Linux patch without idl changes
http://bugzilla.opendarwin.org/attachment.cgi?id=9691&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
Looks great. Needs change log, otherwise the committer has to write a change
log for you.
Looks like for some of the bakefile changes you are using tabs instead of
spaces (or vice versa). Would be better to be consistent.
Ready to check in, but review- because of the lack of ChangeLog.
r=me
More information about the webkit-reviews
mailing list