[webkit-reviews] review denied: [Bug 10096] Bring linux port uptodate : [Attachment 9666] Pathc to build on linux

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 10096: Bring linux port uptodate
http://bugzilla.opendarwin.org/show_bug.cgi?id=10096

Attachment 9666: Pathc to build on linux
http://bugzilla.opendarwin.org/attachment.cgi?id=9666&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I don't understand why we're patching the $Id parts. It's possible we need to
set the subversion flags that prevent is from modifying $Id sequences.

The change in kjs_html.h looks wrong to me. Could you explain that? It's
formatted wrong and just says FIXME. I don't want something like that in the
tree without an explanation.

The change to HTMLOptionsCollection doesn't look right, and before I'd land it
I'd need to see more explanation of why it's changed.

Need a ChangeLog.

As I've said in the past, if you make a smaller patch that doesn't try to do
everything at once, and leave out the more complex or controversial bits, you
can get most of this in, then we can discuss the part that's interesting
separately.

+    FrameGdk(Page*,Element*);

Formatting wrong, needs a space after the comma.