[webkit-reviews] review denied: [Bug 9867] REGRESSION: code that modifies form element in Firefox modifies form attribute in WebKit : [Attachment 9656] lacking changelog, looking for code review

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Jul 24 20:54:16 PDT 2006


Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 9867: REGRESSION: code that modifies form element in Firefox modifies form
attribute in WebKit
http://bugzilla.opendarwin.org/show_bug.cgi?id=9867

Attachment 9656: lacking changelog, looking for code review
http://bugzilla.opendarwin.org/attachment.cgi?id=9656&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks fine, although I might have suggested an alternate form of HasNameGetter
instead of an entirely separate attribute.

My only question is whether we want the name getter to override all the
attributes or only some.

If you add a change log and layout tests, then this would be a review+ I think.



More information about the webkit-reviews mailing list