[webkit-reviews] review denied: [Bug 8980] ASSERTION FAILED: !isLoaded (WebKit/WebKit/Plugins/WebBasePluginPackage.m:228 -[WebBasePluginPackage dealloc]) : [Attachment 9660] Unload those "throw-away" packages

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Jul 24 18:02:21 PDT 2006


Tim Omernick <timo at apple.com> has denied Tim Omernick <timo at apple.com>'s
request for review:
Bug 8980: ASSERTION FAILED: !isLoaded
(WebKit/WebKit/Plugins/WebBasePluginPackage.m:228 -[WebBasePluginPackage
dealloc])
http://bugzilla.opendarwin.org/show_bug.cgi?id=8980

Attachment 9660: Unload those "throw-away" packages
http://bugzilla.opendarwin.org/attachment.cgi?id=9660&action=edit

------- Additional Comments from Tim Omernick <timo at apple.com>
Mitz and I talked about this on IRC.  This is kind of almost correct, but would
do the wrong thing for plugins that are already in the plugin database.  In
that case you would not want to unload those plugins.

I think the best approach would be to ensure that the "throw-away" plugins
(ones representing plugins already in the database) are never loaded in the
first place.  It's a little odd that our plugin packages are "lazily loaded",
but they do their lazy loading in -init.



More information about the webkit-reviews mailing list