[webkit-reviews] review denied: [Bug 8980] ASSERTION FAILED: !isLoaded (WebKit/WebKit/Plugins/WebBasePluginPackage.m:228 -[WebBasePluginPackage dealloc]) : [Attachment 9658] Don't leave the package loaded on return from -pListForPath:createFile: if it wasn't loaded on entry

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Jul 24 15:47:19 PDT 2006


Tim Omernick <timo at apple.com> has denied Tim Omernick <timo at apple.com>'s
request for review:
Bug 8980: ASSERTION FAILED: !isLoaded
(WebKit/WebKit/Plugins/WebBasePluginPackage.m:228 -[WebBasePluginPackage
dealloc])
http://bugzilla.opendarwin.org/show_bug.cgi?id=8980

Attachment 9658: Don't leave the package loaded on return from
-pListForPath:createFile: if it wasn't loaded on entry
http://bugzilla.opendarwin.org/attachment.cgi?id=9658&action=edit

------- Additional Comments from Tim Omernick <timo at apple.com>
I don't think this is the right fix.

If -pListForPath: is the first method to call -load, then the plug-in will be
unnecessarily loaded/unloaded once for all legitimate plug-ins.

Maybe -[WebPluginDatabase refresh] should explicitly unload the "throw-away"
packages



More information about the webkit-reviews mailing list