[webkit-reviews] review denied: [Bug 8425] opacity on a group containing a blur filtered rect crashes : [Attachment 9630] Fix for 8425 and by extension 6947

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Jul 23 10:55:04 PDT 2006


Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 8425: opacity on a group containing a blur filtered rect crashes
http://bugzilla.opendarwin.org/show_bug.cgi?id=8425

Attachment 9630: Fix for 8425 and by extension 6947
http://bugzilla.opendarwin.org/attachment.cgi?id=9630&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
But also, it's better to just do this with API instead of SPI. Just create and
use an autorelease pool in the right place.
    NSAutoreleasePool* pool = [[NSAutoreleasePool alloc] init];
    m_filterCIContext = HardRetain([CIContext contextWithCGContext:cgContext
options:contextOptions]);
    [pool drain];

KCanvasFilterQuartz::prepareFilter shhould not use this SPI either -- same
technique can be used there.



More information about the webkit-reviews mailing list