[webkit-reviews] review granted: [Bug 8272] Use of window.open & window.close can cause crash : [Attachment 9571] revised fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Jul 19 22:50:16 PDT 2006


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 8272: Use of window.open & window.close can cause crash
http://bugzilla.opendarwin.org/show_bug.cgi?id=8272

Attachment 9571: revised fix
http://bugzilla.opendarwin.org/attachment.cgi?id=9571&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I like this one a lot better.

I prefer a slightly different style for the current event constructor.
Something like:

    private:
	enum CurrentEventType { CurrentEvent };
	PlatformMouseEvent(CurrentEventType);

    public:
	static PlatformMouseEvent currentEvent();

and then:

    PlatformMouseEvent event = PlatformMouseEvent::currentEvent();

What you've done is quite similar, and pretty good, but I think mine is
slightly better.

r=me (if you decide not to do it my way; seems good to go as-is)



More information about the webkit-reviews mailing list