[webkit-reviews] review denied: [Bug 8272] Use of window.open & window.close can cause crash : [Attachment 9527] proposed fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Jul 17 11:44:28 PDT 2006

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 8272: Use of window.open & window.close can cause crash

Attachment 9527: proposed fix

------- Additional Comments from Darin Adler <darin at apple.com>
I think it's lame that the default constructor picks up the current event. We
should change the default so it works like this and change the current event
constructor to be a named static member function. That would be a better way to
fix this.

Between that and the lack of a change log I'm going to review- this, but I
agree completely about the approach to a fix.

More information about the webkit-reviews mailing list