[webkit-reviews] review requested: [Bug 8272] Use of window.open & window.close can cause crash : [Attachment 9527] proposed fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Jul 17 11:11:20 PDT 2006


Alexey Proskuryakov <ap at nypop.com> has asked  for review:
Bug 8272: Use of window.open & window.close can cause crash
http://bugzilla.opendarwin.org/show_bug.cgi?id=8272

Attachment 9527: proposed fix
http://bugzilla.opendarwin.org/attachment.cgi?id=9527&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at nypop.com>
This seems to be a bug in Cocoa: [[NSApp currentEvent] window] is invalid.
Filed as <rdar://4634031>.

Looks like m_mouseDown doesn't need to be initialized to the current event here
anyway, so I made it initialize with zeros.

I don't see how to make a sensible layout test for this problem.



More information about the webkit-reviews mailing list