[webkit-reviews] review requested: [Bug 4258] Date().toString() only includes GMT offset, not timezone string : [Attachment 9500] First attempt

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Jul 16 12:06:49 PDT 2006


Rob Buis <rwlbuis at gmail.com> has asked	for review:
Bug 4258: Date().toString() only includes GMT offset, not timezone string
http://bugzilla.opendarwin.org/show_bug.cgi?id=4258

Attachment 9500: First attempt
http://bugzilla.opendarwin.org/attachment.cgi?id=9500&action=edit

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
When in utc mode, I just use tm_zone info here. This should be ok since
localtime
should set it up correctly. Unfortunately there seem to be no tests for this. I
used
http://sackheads.org/~jpayne/timestring.html to test manually, and it matches
Mozilla.
Let me know if any tests should be added or whether we can reuse existing
tests.
Cheers,

Rob.



More information about the webkit-reviews mailing list