[webkit-reviews] review denied: [Bug 5257] setYear() does not match
FireFox/IE behavior : [Attachment 9468] First attempt
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Sun Jul 16 02:25:44 PDT 2006
Geoffrey Garen <ggaren at apple.com> has denied Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 5257: setYear() does not match FireFox/IE behavior
http://bugzilla.opendarwin.org/show_bug.cgi?id=5257
Attachment 9468: First attempt
http://bugzilla.opendarwin.org/attachment.cgi?id=9468&action=edit
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
This patch actually matches the logic in the spec (although it's inverted):
4. If Result(2) is not NaN and 0 <= ToInteger(Result(2)) <= 99 then Result(4)
is ToInteger(Result(2)) + 1900. Otherwise, Result(4) is Result(2).
No testcase is needed if this fixes an existing testcase, but you should attach
updated results for the testcases you've fixed. (r- for that)
More information about the webkit-reviews
mailing list