[webkit-reviews] review requested: [Bug 9875] Teach svn-apply and svn-unapply to use patch(1) for additions and deletions : [Attachment 9473] Patch v1

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Jul 15 20:07:22 PDT 2006


David Kilzer (ddkilzer) <ddkilzer at kilzer.net> has asked  for review:
Bug 9875: Teach svn-apply and svn-unapply to use patch(1) for additions and
deletions
http://bugzilla.opendarwin.org/show_bug.cgi?id=9875

Attachment 9473: Patch v1
http://bugzilla.opendarwin.org/attachment.cgi?id=9473&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at kilzer.net>
Most of the changes are self-explanitory.

The worst code is for reversing a deletion.
- We handle a local file existing (when one shouldn't) by renaming it to
*.orig.
- We unapply the deletion (which creates the file), but we rename it to a temp
file name before running svn revert in case the contents are the same.
- After we rename the temp file back to the original file name, we must work
around a timestamp bug in Subversion where the svn client thinks the file
hasn't change if its timestamp isn't sufficiently different.



More information about the webkit-reviews mailing list