[webkit-reviews] review granted: [Bug 9903] Simplify logic in
JSHTMLOptionsCollection::setLength() by using no-arg
getNumber() : [Attachment 9439] Patch v2
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Fri Jul 14 01:27:09 PDT 2006
Geoffrey Garen <ggaren at apple.com> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 9903: Simplify logic in JSHTMLOptionsCollection::setLength() by using
no-arg getNumber()
http://bugzilla.opendarwin.org/show_bug.cgi?id=9903
Attachment 9439: Patch v2
http://bugzilla.opendarwin.org/attachment.cgi?id=9439&action=edit
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
That's right. This patch enables landing the getNumber part of my
JavaScriptCore patch:
{
if (JSImmediate::isImmediate(this)) {
v = JSImmediate::toDouble(this);
- return true;
+ return JSImmediate::isNumber(this);
}
return downcast()->getNumber(v);
More information about the webkit-reviews
mailing list