[webkit-reviews] review denied: [Bug 9742] REGRESSION: WebKit hangs when loading <http://www.vtbook.com> : [Attachment 9429] Updated patch including ChangeLog entry for the layout test

[bugzilla-request-daemon at opendarwin.org]

Geoffrey Garen <ggaren at apple.com> has denied Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 9742: REGRESSION: WebKit hangs when loading <http://www.vtbook.com>
http://bugzilla.opendarwin.org/show_bug.cgi?id=9742

Attachment 9429: Updated patch including ChangeLog entry for the layout test
http://bugzilla.opendarwin.org/attachment.cgi?id=9429&action=edit

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Great catch!

Two objections:

1. JavaScript layout tests should be written as pure JavaScript, and the HTML
to run them in DumpRenderTree generated by the
/WebKitTools/Scripts/make-js-test-wrappers script. You can see example .js
files in LayoutTests/fast/js/resources. The reason for this is that we want to
be able to run these tests outside of the browser, too.

2. It looks like the other get functions, like getNumber, have the same issue.
It would be best to change them too.

Note to commiter: We'll need to performance test the final patch before
landing, since it may change the inlining behavior of some hot functions.