[webkit-reviews] review requested: [Bug 9651] MSVCRT time functions
are too strict : [Attachment 9351] Custom implementaion of
time functions in WTF, not inlined
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Mon Jul 10 20:15:41 PDT 2006
Björn Graf (boki) <bjoern.graf at gmail.com> has asked for review:
Bug 9651: MSVCRT time functions are too strict
http://bugzilla.opendarwin.org/show_bug.cgi?id=9651
Attachment 9351: Custom implementaion of time functions in WTF, not inlined
http://bugzilla.opendarwin.org/attachment.cgi?id=9351&action=edit
------- Additional Comments from Björn Graf (boki) <bjoern.graf at gmail.com>
This patch is the same as before with Darins comments applied. New to this
patch is the use of wcsftime over strftime and the minimal implementation of
wcsftime to support DateProtoFunc::callAsFunction() on Windows. While I am not
absolutely sure if the use of wcsftime is better than using strftime and let
the convertion from the system code page to Unicode be performed by UString it
feels more logical to get the Unicode string and save the conversion.
More information about the webkit-reviews
mailing list