[webkit-reviews] review denied: [Bug 9651] MSVCRT time functions are too strict : [Attachment 9244] Custom implementaion of time functions in WTF

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 9651: MSVCRT time functions are too strict
http://bugzilla.opendarwin.org/show_bug.cgi?id=9651

Attachment 9244: Custom implementaion of time functions in WTF
http://bugzilla.opendarwin.org/attachment.cgi?id=9244&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks like a step in the right direction.

But why are all these functions entirely inlined? That doesn't seem right for
code as big as this. Lets put the implementation in the .cpp file.

In yearFromTime, it looks to me like the code would be better if instead of
calling floor in the year expression the code simply cast to (int). That does
the floor "for free" and we want year to be an int anyway. The only uses of it
are casted to int later and the only operation done subsequently is to subtract
1.

This looks great. Please fix DateExtras.h to not be all inline, and then lets
get that in!