[webkit-reviews] review granted: [Bug 9753] SVG with width and height 100% leaves room for scrollbar on the right. : [Attachment 9296] First attempt

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Jul 9 07:46:40 PDT 2006


Eric Seidel <macdome at opendarwin.org> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 9753: SVG with width and height 100% leaves room for scrollbar on the
right.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9753

Attachment 9296: First attempt
http://bugzilla.opendarwin.org/attachment.cgi?id=9296&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
Looks good.

There are a couple mis-placed *'s:
RenderObject *
RenderPath *

Also, I've more commonly seen multi-line ifs broken before the binary operator,
instead of after, example:
if (foo
   || bar
   || baz)

Not sure if there is an official practice in that regard or not.

r=me.



More information about the webkit-reviews mailing list