[webkit-reviews] review requested: [Bug 8251] netscape.product incorrect in WebKit.app on Intel Macs : [Attachment 9275] Improved patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Jul 8 11:01:50 PDT 2006


Rob Buis <rwlbuis at xs4all.nl> has asked	for review:
Bug 8251: netscape.product incorrect in WebKit.app on Intel Macs
http://bugzilla.opendarwin.org/show_bug.cgi?id=8251

Attachment 9275: Improved patch
http://bugzilla.opendarwin.org/attachment.cgi?id=9275&action=edit

------- Additional Comments from Rob Buis <rwlbuis at xs4all.nl>
Hi Darin, Justin,

I interpreted the suggestions a bit wrong, I thought the macro should go into
Platform.h, you
probably meant just using Platform.h macros. This time I tried to merge both
your suggestions. Let
me know if a testcase is required (I tested using
http://www.robinlionheart.com/stds/html4/objects)
and if so, how to go about the multi-platform aspect.
Cheers,

Rob.



More information about the webkit-reviews mailing list